Root query: generate {x}Option
method for fields with an optional interface type
#1223
+274
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientWriter
does not handle optional interfaces properly of the root query.I fixed the processing of the root query in the scope of the PR. If the output type of a field is an interface, the
ClientWriter
will generate two methods:def {x}(...)
anddef {x}Option(...)
.Schema 1 (without root schema)
ClientWriter
generates two methods:node(id: ID)(...)
andnodeOption(id: ID)(...)
.Schema 2 (with top-level
schema
definition)ClientWriter
generates only one method:node(id: ID)(...)
.